[Keyvault] Fix #16318: az keyvault certificate download crash on Python 3.9 due to removed method call #16319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianfosli
requested review from
bim-msft,
fengzhou-msft,
houk-ms and
yungezz
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution christianfosli! We will review the pull request and get back to you soon. |
christianfosli
changed the title
Collaborator
|
Keyvault |
Member
|
hi @houk-ms could you pls have a review? thanks |
…ate download `base64.encodestring()` has been a deprecated alias for `base64.encodebytes()` since Python 3.1, and have has now been removed in Python 3.9. This replaces the removed/deprecated method with the one it was aliased to. Fixes #16318
Contributor
Author
|
Force-push: rebase on dev |
houk-ms
approved these changes
Jan 25, 2021
Contributor
houk-ms
left a comment
houk-ms
left a comment
There was a problem hiding this comment.
LGTM. Thanks @christianfosli for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
base64.encodestring()method has been deprecated since Python 3.1 and removed in Python 3.9This fixes crash for
azure keyvault certificate download, as described in #16318Testing Guide
Please verify that
az keyvault certificate downloadworks as intended.History Notes
[Keyvault] az keyvault certificate download: Fix deprecated/removed method call
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.